Skip to content

feat: Add new singular data source mongodbatlas_cloud_user_project_assignment #3569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 13, 2025
Merged

feat: Add new singular data source mongodbatlas_cloud_user_project_assignment #3569

merged 20 commits into from
Aug 13, 2025

Conversation

csanx
Copy link
Collaborator

@csanx csanx commented Aug 7, 2025 •
edited
Loading

Description

Add new singular data source: mongodbatlas_cloud_user_project_assignment

Link to any related issue(s): CLOUDP-333177

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@csanx csanx changed the base branch from master to CLOUDP-333176 August 7, 2025 12:42
@csanx csanx marked this pull request as ready for review August 11, 2025 08:00
@csanx csanx requested review from a team as code owners August 11, 2025 08:00
@github-actions GitHub Actions
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

@csanx csanx mentioned this pull request Aug 11, 2025
Open
13 tasks
EspenAlbert
EspenAlbert reviewed Aug 12, 2025
View reviewed changes
internal/service/clouduserprojectassignment/resource_migration_test.go Outdated
@@ -128,7 +128,7 @@ func removeProjectInvitationConfigThird(username, projectName, orgID string, rol
`, username, rolesStr, projectName, orgID)
}

func checksSecond(username, projectName string, roles []string) resource.TestCheckFunc {
func checksSecond(username string, roles []string) resource.TestCheckFunc {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we managing the project as part of this test?
Can we not use ProjectIDExecution?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can, thanks for pointing that out! Updated it

maastha
maastha reviewed Aug 12, 2025
View reviewed changes
internal/service/clouduserprojectassignment/resource_test.go Outdated
roles = [%[5]s]
}

data "mongodbatlas_cloud_user_project_assignment" "testUsername" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: stay consistent with format used for naming resources/data sources, for example, for resource you used test_active (with an _) but here uou name it testUsername (different casing).
Use one format consistently & this applies to all tests, examples, documentation etc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, changed it to be consistent

maastha
maastha approved these changes Aug 12, 2025
View reviewed changes
Copy link
Collaborator

@maastha maastha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once naming in tests is consistent:)

Cristina Sánchez Sánchez added 2 commits August 13, 2025 09:53
@csanx csanx merged commit bb955c5 into CLOUDP-333176 Aug 13, 2025
42 checks passed
@csanx csanx deleted the CLOUDP-333177 branch August 13, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EspenAlbert EspenAlbert EspenAlbert left review comments

@marcosuma marcosuma marcosuma approved these changes

@jwilliams-mongo jwilliams-mongo jwilliams-mongo approved these changes

@oarbusi oarbusi oarbusi approved these changes

@maastha maastha maastha approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@csanx @EspenAlbert @marcosuma @jwilliams-mongo @oarbusi @maastha